Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] remove deprecated code #6178

Merged
merged 1 commit into from
Oct 3, 2022
Merged

[chore] remove deprecated code #6178

merged 1 commit into from
Oct 3, 2022

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Sep 28, 2022 •
edited
Loading

No description provided.

@codeboten codeboten requested review from a team and bogdandrutu September 28, 2022 20:20
@codeboten codeboten force-pushed the codeboten/rm-deprecated-61 branch from bd7d39c to 2f94ced Compare September 28, 2022 20:51
@codeboten codeboten changed the title remove deprecated go.opentelemetry.io/collector/service/featuregate remove deprecated code Sep 28, 2022
@codeboten codeboten changed the title remove deprecated code [chore] remove deprecated code Sep 28, 2022
@dmitryax
Copy link
Member

dmitryax commented Sep 28, 2022 •
edited
Loading

@codeboten PTAL #6170. It should help with failing tests

@codeboten
Copy link
Contributor Author

Thanks @dmitryax! Yes i saw your PR and realized after submitting this one that it wont pass until yours is merged

@codeboten codeboten force-pushed the codeboten/rm-deprecated-61 branch from 2f94ced to 130dd96 Compare September 29, 2022 01:26
@bogdandrutu
Copy link
Member

Please rebase.

@codeboten codeboten force-pushed the codeboten/rm-deprecated-61 branch from 130dd96 to a32b62d Compare September 29, 2022 17:27
@bogdandrutu
Copy link
Member

@codeboten you need to also remove the tests for the deprecated funcs. @dmitryax loves to leave them behind :))

@dmitryax
Copy link
Member

dmitryax commented Sep 29, 2022 •
edited
Loading

Haha I left tests for Clone intentionally to avoid dropped coverage. others were missed :)

@codeboten
Copy link
Contributor Author

@bogdandrutu @dmitryax yup... on it :)

@codeboten codeboten force-pushed the codeboten/rm-deprecated-61 branch from 597cd85 to 651345d Compare September 29, 2022 18:13
@codecov
Copy link

codecov bot commented Sep 29, 2022 •
edited
Loading

Codecov Report

Base: 91.87% // Head: 92.10% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (651345d) compared to base (711b882).
Patch has no changes to coverable lines.

❗ Current head 651345d differs from pull request most recent head 777a877. Consider uploading reports for the commit 777a877 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6178      +/-   ##
==========================================
+ Coverage   91.87%   92.10%   +0.22%     
==========================================
  Files         219      218       -1     
  Lines       13533    13295     -238     
==========================================
- Hits        12434    12245     -189     
+ Misses        870      821      -49     
  Partials      229      229
Impacted Files Coverage Δ
pdata/pcommon/common.go 93.51% <ø> (+3.59%) ⬆️
pdata/plog/logs.go 96.00% <ø> (-0.56%) ⬇️
pdata/plog/plogotlp/logs.go 51.06% <ø> (ø)
pdata/pmetric/metrics.go 97.53% <ø> (+22.07%) ⬆️
pdata/pmetric/pmetricotlp/metrics.go 55.81% <ø> (ø)
pdata/ptrace/ptraceotlp/traces.go 51.06% <ø> (ø)
pdata/ptrace/traces.go 92.00% <ø> (+10.18%) ⬆️
confmap/confmap.go 90.99% <0.00%> (-2.21%) ⬇️
config/identifiable.go 100.00% <0.00%> (ø)
config/configtelemetry/configtelemetry.go 100.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten
Copy link
Contributor Author

Contrib tests are failing, there is a bunch of work underway to address the issues:

open-telemetry/opentelemetry-collector-contrib#14600
DataDog/datadog-agent#13684
influxdata/influxdb-observability#115
GoogleCloudPlatform/opentelemetry-operations-go#489

@mx-psi mx-psi mentioned this pull request Sep 30, 2022
Merged
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Oct 3, 2022
[chore] bump gcp dependencies
0597772 
bumping the following packages to partially unblock open-telemetry/opentelemetry-collector#6178:
```
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping
```
@codeboten codeboten mentioned this pull request Oct 3, 2022
Merged
bogdandrutu pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Oct 3, 2022
[chore] bump gcp dependencies (#14639)
71dd19d 
bumping the following packages to partially unblock open-telemetry/opentelemetry-collector#6178:
```
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/collector/googlemanagedprometheus
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace
	github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping
```
@codeboten codeboten force-pushed the codeboten/rm-deprecated-61 branch from 651345d to 777a877 Compare October 3, 2022 18:06
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Oct 3, 2022
[chore] bump influxdb deps
bd0e976 
This is the last change to unblock open-telemetry/opentelemetry-collector#6178
@codeboten codeboten mentioned this pull request Oct 3, 2022
Merged
bogdandrutu pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Oct 3, 2022
[chore] bump influxdb deps (#14692)
3347115 
This is the last change to unblock open-telemetry/opentelemetry-collector#6178
@codeboten
Copy link
Contributor Author

All the contrib dependencies have been updated now, this is ready to merge when approved 👍🏻

dmitryax
dmitryax approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeboten!

@codeboten codeboten merged commit d9438c6 into open-telemetry:main Oct 3, 2022
@codeboten codeboten deleted the codeboten/rm-deprecated-61 branch October 4, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @dmitryax @bogdandrutu